fix: ensure imageNames are not empty strings #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note the previously signed CLA is not valid for this code contribution. |
|
This PR is idle because it has been open for 14 days with no activity. |
davidgamero
approved these changes
Jan 31, 2024
|
@Foxboron looks like you need to format with |
Foxboron
force-pushed
the
morten/fix-images
branch
from
1c8d7ec to
2677e40
Compare
In Typescript/Javascript an empty string split on newline is going to
produce an array with an empty string.
=> "".split('\n')
[""]
This causes the action to produce a warning, unless `pull-images` is set
to false.
Failed to get dockerfile path for image : Error: The process '/usr/bin/docker' failed with exit code 1
Filtering the list to remove any zero-length strings from the array
solves this issue.
Signed-off-by: Morten Linderud <[email protected]>
Foxboron
force-pushed
the
morten/fix-images
branch
from
2677e40 to
0e2f65c
Compare
|
Done, but I'll reiterate that the green checkmark from the CLA bot is not applicable for this commit. |
|
@microsoft-github-policy-service rerun |
|
do you mean because of the minimum line/file requirements? |
|
Ah, if that is the portion that triggers then that is fine. I thought I had singed it for my personal contributors at some point and can't tell form the check why it was green. Feel free to merge, thanks :) |
OliverMKing
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Typescript/Javascript an empty string split on newline is going to produce an array with an empty string.
This causes the action to produce a warning, unless
pull-imagesis set to false.Filtering the list to remove any zero-length strings from the array solves this issue.