Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v4.10 #296

Closed
wants to merge 3 commits into from
Closed

Release v4.10 #296

wants to merge 3 commits into from

Conversation

davidgamero
Copy link
Collaborator

@davidgamero davidgamero requested a review from a team as a code owner October 30, 2023 16:28
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 30, 2023
View reviewed changes
src/utilities/kubectl-util.ts

export function getTrafficSplitAPIVersion(kubectl: Kubectl): string {
const result = kubectl.executeCommand('api-versions');
const trafficSplitAPIVersion = result.stdout.split('\n').find(version => version.startsWith(trafficSplitAPIVersionPrefix));

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization High

'
split.smi-spec.io
Loading
' may be followed by an arbitrary host name.
@davidgamero davidgamero deleted the releases/v4.10 branch November 3, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidgamero