Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

omit namespace arg for default namespace #195

Merged
merged 4 commits into from
Jun 15, 2022
Merged

omit namespace arg for default namespace #195

merged 4 commits into from
Jun 15, 2022

Conversation

davidgamero
Copy link
Collaborator

@davidgamero davidgamero commented Jun 14, 2022 •
edited
Loading

ref #163

  • omit namespace arg if namespace == 'default'
  • added unit tests back onto main (they still only ran on master)
  • bump jest version to fix peer dep conflict

@davidgamero davidgamero requested a review from a team as a code owner June 14, 2022 16:35
@davidgamero davidgamero changed the title don't append namespace arg for default namespace omit namespace arg for default namespace Jun 14, 2022
OliverMKing
OliverMKing requested changes Jun 15, 2022
View reviewed changes
src/types/kubectl.ts Outdated Show resolved Hide resolved
@OliverMKing OliverMKing merged commit 15920eb into Azure:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliverMKing OliverMKing OliverMKing approved these changes

@bfoley13 bfoley13 bfoley13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidgamero @bfoley13 @OliverMKing