tests: Fix some missing parallel calls and missing test spans #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
force-pushed
the
improve_ci_times
branch
30 times, most recently
from
4754f3b
to
1a0e72b
Compare
cpuguy83
force-pushed
the
improve_ci_times
branch
4 times, most recently
from
e42d83c
to
792b957
Compare
Signed-off-by: Brian Goff <[email protected]>
Before this was calling `t.Log` for every read from the log file. What we really want is to to call `t.Log` for every line since a `Read` may return a partial line which will look weird in the output and be difficult to read. This also changes things to always write the build logs to the test log instead of just on failure so its easier to see what's happening even on a successful test run. Signed-off-by: Brian Goff <[email protected]>
This prevents the skew of test times due to having to build the frontend and worker images. Signed-off-by: Brian Goff <[email protected]>
This makes sure we use the same cache keys for both the main Dockerfile and the test fixtures so that we can avoid needing to pull down a bunch of dependencies that we've already pulled down before. Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
improve_ci_times
branch
from
e6f66a9
to
a9c74ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.