Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getUploadToken to allow customers to include URL to uploaded log files with Impacts. #31716

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

bryantruong
Copy link

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Copy link

openapi-pipeline-app bot commented Dec 2, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the VersioningReviewRequired label.
  • ❌ This PR has at least one change violating Azure versioning policy (label: VersioningReviewRequired).
    To unblock this PR, either a) introduce a new API version with these changes instead of modifying an existing API version, or b) follow the process at aka.ms/brch.
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link

openapi-pipeline-app bot commented Dec 2, 2024

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Impact

Bryan Truong added 2 commits December 3, 2024 10:51
This reverts commit bd01f4b.

Reverted branch to master. Will recreate with new version number.
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview new-api-version resource-manager RPaaS TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 3, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview added NotReadyForARMReview VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 3, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Alerts Management Analysis Services API Management ArcReview ARMReview Authorization Automation Batch BatchAI Billing Cognitive - Language Cognitive Services Compute Container Instances Container Registry Container Service Cosmos Customer Insights Data Factory Data Lake Analytics Data Lake Store Data Migration Device Update Device Update Service Devtestlab DoNotMerge <valid label in PR review process> use to hold merge after approval Event Grid Event Hubs HDInsight Import Export Insights Intune IoTHub KeyVault Load Test Service Azure Load Test Service Logic App Machine Learning Compute Machine Learning Maps Media Services Mobile Engagement Monitor - Exporter Monitor OpenTelemetry Exporter Monitor - Operational Insights Monitor Monitor, Monitor Ingestion, Monitor Query MySQL Network - CDN Network - DNS Network - Traffic Manager Network new-api-version Notification Hub NotReadyForARMReview Operations Management Peering Policy Insights PostgreSQL Profile Azure API profile issues. Purview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test Recovery Services Backup Recovery Services Site-Recovery RecoveryServices Redis Cache Relay resource-manager RPaaS Scheduler Search Service Bus Service Fabric Service Map SQL Storage Storage Service (Queues, Blobs, Files) StorageSync Storsimple Stream Analytics Subscription Synapses TimeseriesInsights TypeSpec Authored with TypeSpec VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required Web Apps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants