Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading liftr base typespec package version #31705

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nikhgup
Copy link
Contributor

@nikhgup nikhgup commented Nov 29, 2024

Choose a PR Template

Upgrading npm package version to 0.6.0 to include following changes
new ap-version to include

  1. Support for change plan models in base marketplace model
  2. Making firstName and LastName optional.

Have verified with existing RPs and no breaking changes is introduced for old api-version
 
Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Copy link

openapi-pipeline-app bot commented Nov 29, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named Protected Files has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link

openapi-pipeline-app bot commented Nov 29, 2024

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@nikhgup
Copy link
Contributor Author

nikhgup commented Nov 29, 2024

@nikhgup
Copy link
Contributor Author

nikhgup commented Nov 29, 2024

@allenjzhang, @weshaggard @mikeharder do i need to add this package reference to any other file so it can be referenced for SDK generation as well? Currently during SDK generation this package reference is not getting resolved.

@mikeharder
Copy link
Member

@allenjzhang, @weshaggard @mikeharder do i need to add this package reference to any other file so it can be referenced for SDK generation as well? Currently during SDK generation this package reference is not getting resolved.

I don't know how SDK generation decides which versions of which packages to use. @raych1, @hallipr: Do either of you know?

@nikhgup: Can you merge this PR while you are investigating the SDK failures? Or do you want to leave this PR unmerged until you fix the SDK failures as well?

@nikhgup
Copy link
Contributor Author

nikhgup commented Dec 3, 2024

@mikeharder we can merge this PR as this issue is not related to compatibility of package. we are discussing with SDK team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants