Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EG] ServiceBus required/optional #30760

Merged
merged 5 commits into from
Dec 3, 2024
Merged

[EG] ServiceBus required/optional #30760

merged 5 commits into from
Dec 3, 2024

Conversation

l0lawrence
Copy link
Member

No description provided.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 26, 2024 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 26, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
.Net Azure.Messaging.EventGrid.SystemEvents https://apiview.dev/Assemblies/Review/3e102a891e5445af8be8cde833dbb702?revisionId=13837d2fe56a4d259b832cd07a77f733
Python azure-eventgrid https://apiview.dev/Assemblies/Review/c554ddbabc6e40348998b1656e0ff585?revisionId=0a8c0add3a4f4847b383b8a9ccd51fd5
TypeSpec Azure.Messaging.EventGrid.SystemEvents https://apiview.dev/Assemblies/Review/bf48b2982ff74cd796f5900a221af2d5?revisionId=eaafc310015544feb68372fa70894f64

@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane TypeSpec Authored with TypeSpec labels Sep 26, 2024
@azure-sdk azure-sdk mentioned this pull request Sep 26, 2024
Draft
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.ApiCenter

This was referenced Dec 2, 2024
Draft
Draft
@l0lawrence l0lawrence marked this pull request as ready for review December 3, 2024 18:47
@lmazuel lmazuel added BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior and removed BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required labels Dec 3, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Dec 3, 2024
lmazuel
lmazuel approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with service team

@lmazuel lmazuel added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Dec 3, 2024
@lmazuel lmazuel merged commit dcb1a57 into Azure:main Dec 3, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel lmazuel approved these changes

@Kishp01 Kishp01 Awaiting requested review from Kishp01 Kishp01 is a code owner

Assignees
No one assigned
Labels
BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane Event Grid PublishToCustomers Acknowledgement the changes will be published to Azure customers. TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@l0lawrence @azure-sdk @lmazuel @AzureRestAPISpecReview