Updated dependencies to fix breaking changes in requests #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanwinter
approved these changes
Jul 9, 2024
|
resolves #1187? |
ryanwinter
requested changes
Jul 10, 2024
| @@ -693,6 +694,10 @@ async def test_raises_error_when_message_size_greater_than_256(self, client, mqt | |||
| assert "256 KB" in e_info.value.args[0] | |||
| assert mqtt_pipeline.send_message.call_count == 0 | |||
|
|
|||
| @pytest.mark.skipif( | |||
There was a problem hiding this comment.
What are these python 3.12 issues? Does this impact the customer at all? Looks like if they have large messages they might not get an error?
There was a problem hiding this comment.
Yeah - but honestly, this max size never actually worked in practice, so it's not an issue.
|
/azp run Python E2E |
|
No pipelines are associated with this pull request. |
|
/azp run Azure.azure-iot-sdk-python-dps-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Python E2E |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ryanwinter
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestshad critical security fixes that required updating minimum versionrequests-unixsocketdependency which used monkey-patchingrequests-unixsocketis abandoned, so switched to use the forkrequests-unixsocket2urllib3dependency to be more flexible.