-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add azure runtime config flag to cs service template #621
Conversation
config.json: | | ||
{ | ||
"cloudEnvironment": "AzurePublicCloud" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In CS, we have a parameter that takes a json obj and set it here (see MR#8478)
config.json: ${AZURE_RUNTIME_CONFIG}
I see that the rest of the configmap values are hardcoded here so i've kept it the same. Is there a preference to parameterise this? Additional configuration that would be added here for example would be ACR configuration that's used in CS (see related jira issue ARO-9331).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once additional dynamic configuration is required for an env, you can do something like this here
so basically templating individual inner fields of the json value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah perfect! I think we can do this as a follow on task, for now we can start with the hardcoded configmap 👍 jira issue to track this: https://issues.redhat.com/browse/ARO-10539
@microsoft-github-policy-service agree company="Red Hat" |
98ac657
to
3bfc95a
Compare
What this PR does
Adds a configmap containing the azure runtime configuration in the ARO HCP CS service template. This is used as value to the flag
azure-runtime-config
which has been added in https://gitlab.cee.redhat.com/service/uhc-clusters-service/-/merge_requests/8478Current configuration available to be set here is the cloud environment where CS is running on. For now, only the cloud environment is added there. Additional configuration will be added at a later time.
CS image tag has been updated to 9da687c which contains the changes in the MR linked above.
Jira: https://issues.redhat.com/browse/ARO-7653
Link to demo recording: N/A
Special notes for your reviewer
Please note that this depends on https://gitlab.cee.redhat.com/service/uhc-clusters-service/-/merge_requests/8478. The cs image in the makefile will be updated as soon as that's merged.