Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overwrite for secrets #616

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Support overwrite for secrets #616

merged 3 commits into from
Sep 18, 2024

Conversation

janboll
Copy link
Collaborator

@janboll janboll commented Sep 17, 2024

Various quay orgs might require different secrets, thus allow chaning secret identifier

What this PR does

Jira:
Link to demo recording:

Special notes for your reviewer

Various quay orgs might require different secrets, thus allow chaning secret identifier
Copy link
Collaborator

@geoberle geoberle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i observed concurrency issues on multiple ARM RPs when creating things in parallel of the same kind. would you add @\batch annotations to the resourcelists to prevent that?

@janboll
Copy link
Collaborator Author

janboll commented Sep 18, 2024

I tried it with a new ACR, no issues. So I'd not add the batch annotation

@janboll janboll requested a review from geoberle September 18, 2024 07:15
@janboll janboll merged commit dd17e82 into main Sep 18, 2024
24 checks passed
@janboll janboll deleted the use-correct-secrets branch September 18, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants