Add shellcheck linter for Makefiles

Signed-off-by: Alba Hita Catala <[email protected]>
Azure · Sep 18, 2024 · 5d622a3 · 5d622a3
1 parent a089517
commit 5d622a3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.mega-linter.yml b/.mega-linter.yml
@@ -5,8 +5,13 @@
 APPLY_FIXES: none
 ENABLE_LINTERS:
   - YAML_YAMLLINT
+  - BASH_SHELLCHECK
 EXCLUDED_DIRECTORIES:
   - "node_modules"
+BASH_SHELLCHECK_ARGUMENTS:
+  - -i1101 -f gcc
+BASH_SHELLCHECK_FILE_NAMES_REGEX:
+  - "Makefile"
 LINTER_RULES_PATH: .
 PRINT_ALPACA: false
 GITHUB_STATUS_REPORTER: false

diff --git a/cluster-service/Makefile b/cluster-service/Makefile
@@ -24,7 +24,7 @@ deploy:
 	AZURE_FIRST_PARTY_APPLICATION_CLIENT_ID=$(shell az ad app list \
 			--display-name aro-hcp-dev-first-party \
 			--query '[*]'.appId \
-			-o tsv) && \
+			-o tsv) && \ 
 	CS_SERVICE_PRINCIPAL_CREDS_BASE64='$(shell az keyvault secret show --vault-name "service-kv-aro-hcp-dev" --name "aro-hcp-dev-sp-cs" | jq .value -r | base64 | tr -d '\n')' && \
 	TENANT_ID=$(shell az account show --query tenantId --output tsv) && \
 	oc process --local -f deploy/openshift-templates/arohcp-service-template.yml \