Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Key Vault Soft Delete Flag #874

Draft
wants to merge 2 commits into
base: feat/e2e-databricks-updates
Choose a base branch
from

Conversation

elenaterenzi
Copy link
Contributor

Type of PR

  • Documentation changes
  • Code changes

Purpose

Does this introduce a breaking change? If yes, details on what can break

no breaking change

Author pre-publish checklist

  • Added test to prove my fix is effective or new feature works
  • No PII in logs
  • Made corresponding changes to the documentation

Validation steps

  • tested with flag set to true, and no flag set.
    • When the flag is not set the key vault is created with soft delete (default).
    • When the flag is set, a key vault is created setting the soft delete option according to the flag. If the flag is set to false, soft-delete will not be enabled.

Issues Closed or Referenced

ydaponte and others added 2 commits November 18, 2024 09:51
…-fork-reference

fix: REST API broken links, Int testing devcontainer upgrade
Copy link

@thesqlpro thesqlpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to synchronize on the AZ Login portion as there is an open PR on it #880

- Ensure that:
- You are logged in to the Azure CLI. To login, run

```bash
az login
az config set core.login_experience_v2=off
az login --tenant $TENANT_ID

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In task #685 we are removing Az Login from the individual scripts and instead including it in the pre-requisites documentation. We should sync up on this as I have a PR open to make things consistent. It has not been pushed yet. PR #880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants