Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the name of the spring apps instance to be globally unique. #31

Merged

Conversation

pmalarme
Copy link
Collaborator

Fix the name of the spring apps instance to be globally unique. Add some more defences to globally unique name to be sure it always insert the unique part.

Purpose

  • Use globally unique name for Spring Apps
  • Improve globally unique resource name by ensuring that the unique string is always present in the name when generated
  • Improve the documentation of the parameters
  • Test the changes

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Create a new environment named dev with azd env new
  • Deploy the solution
  • Check that the deployment works and that the solution is working too

What to Check

Verify that the following are valid

  • The deployment complete until the end without errors
  • The application is running properly
  • The documentation of the parameters is precise

Other Information

…ome more defence to globally unique name to be sure it always insert the unique part.
@pmalarme pmalarme linked an issue Aug 21, 2023 that may be closed by this pull request
@pmalarme pmalarme requested a review from aarthiem August 21, 2023 10:07
@github-actions github-actions bot added the automation: infra Infrastructure as Code (IaC) label Aug 21, 2023
Copy link
Collaborator

@aarthiem aarthiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@pmalarme pmalarme merged commit 06270b7 into main Aug 25, 2023
2 checks passed
@pmalarme pmalarme deleted the fix/29-spring-apps-name-should-be-unique-in-bicep-templates branch August 25, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation: infra Infrastructure as Code (IaC)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spring apps name should be unique in bicep templates
2 participants