Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: add bodyParser to read order json #47

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

pauldotyu
Copy link
Contributor

Purpose

  • Fixes a bug in the order checkout page in the store-front app where request body was not being sent to order-service

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Run the store-front and manually submit an order
git clone https://github.com/Azure-Samples/aks-store-demo
cd aks-store-demo
git checkout fix-checkout
cd src/store-front
docker compose up --build
# in a new terminal
npm run serve
  • Test the code
  • Navigate to store frontend site
  • Add an item to the cart
  • Checkout

What to Check

Verify that the following are valid

Copy link
Collaborator

@chzbrgr71 chzbrgr71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chzbrgr71 chzbrgr71 merged commit 8701b0e into main Aug 2, 2023
4 checks passed
@pauldotyu pauldotyu deleted the fix-checkout branch August 8, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants