Reduce logging to the minimum required for operation #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rest of the log lines are reduced to debug, so that users can debug their connection if needed. For normal operation, this is not needed. From now on, we will log: - Upon connection it will log it's connected and the settings retrieved - upon the 5th failure of connection, it will log the connection error once That's it. We don't want to spam the logs of the users when we deploy. The log during deployments is thus reduced to: ``` Connection to AxonIQ Console set up successfully! Settings: ClientSettingsV2(heartbeatInterval=10000, hear... This application has lost it's connection to AxonIQ Console. Reconnection will be automatically attempted. Connection to AxonIQ Console set up successfully! Settings: ClientSettingsV2(heartbeatInterval=10000, hear... ``` When we are offline, it will be similar to: ``` Connection to AxonIQ Console set up successfully! Settings: ClientSettingsV2(heartbeatInterval=10000, heartbeatTimeout=30000, processorReportInterval=2000, handlerReportInte This application has lost it's connection to AxonIQ Console. Reconnection will be automatically attempted. Failed to connect to AxonIQ Console. Error: io.netty.channel.AbstractChannel$AnnotatedConnectException: finishConnect(..) failed: Connection refused: localhost/127.0.0.1:700 ```
CodeDrivenMitch
requested review from
gklijs,
corradom,
smcvb,
sandjelkovic and
stefanmirkovic
and removed request for
a team
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rest of the log lines are reduced to debug, so that users can debug their connection if needed. For normal operation, this is not needed.
From now on, we will log:
That's it. We don't want to spam the logs of the users when we deploy. The log during deployments is thus reduced to:
When we are offline, it will be similar to: