Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(acap-build)!: Support files named in manifest #139

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(acap-build)!: Support files named in manifest #139

wants to merge 3 commits into from
+239 −172

Conversation

apljungquist
Copy link
Contributor

No description provided.

@apljungquist apljungquist requested a review from a team as a code owner November 26, 2024 19:19
@apljungquist apljungquist changed the title fix(acap-build)!: Support installation scripts feat(cargo-acap-build)!: Gather all application files from one directory Nov 27, 2024
@apljungquist apljungquist changed the title feat(cargo-acap-build)!: Gather all application files from one directory feat(acap-build)!: Support files named in manifest Nov 27, 2024
@apljungquist
s: Factor out breaking changes
053d356 
Comments related to the PR but not necessarily to this commit:

`apps/using_a_build_script/build.rs`:
- Keep using the term "additional" despite renaming the directory
  because the file generated by this function is additional in the
  sense that the acap-build crate uses the word.
- Remove the `applications-files/` directory on each run to avoid
  including files that are no longer generated in the package. This
  behavior can be surprising and it is not immediately clear what is
  going on since the out directory is out of sight and sometimes
  there are multiple out directories for the same crate that can be
  easily confused.
@apljungquist apljungquist changed the title feat(acap-build)!: Support files named in manifest feat(acap-build): Support files named in manifest Nov 27, 2024
@apljungquist apljungquist changed the title feat(acap-build): Support files named in manifest feat(acap-build)!: Support files named in manifest Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@apljungquist