feat(acap-build): Allow building apps without the ACAP Native SDK #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`apps/challenge_build_tools/manifest.json`: - `acapPackageConf.setup.version` is chosen to utilize much of the flexibility allowed by SemVer. - The values set are those that handled explicitly or that affect any of the generated files. - `acapPackageConf.copyProtection.customOptions` is not set because the manifest validation rejects extra values. - pre-uninstall and post-install scripts are omitted because the reference implementation would try and fail to open them. I choose to not implement support at this time because this commit is already big and it is not obvious how to expose this functionality. `crates/acap-build/src/bin/acap-build.rs`: - The purpose of this binary is twofold. First to replace `acap-build` in the docker images of `acap-native-sdk-examples` to demonstrate that the result is exactly the same (except for one example that doesn't produce reproducible shared object files). Second to document the progress on making the equivalent implementation capable of supporting the API of the original program. `crates/acap-build/src/files/package_conf.rs`: - Flattening is not implemented for arrays because it is not needed and it makes handling `acapPackageConf.configuration.httpConfig` more straight forward since we can match on the entire path and we don't have to consider triggering the case multiple times. - Parameters set by special cases don't have a source set even if they could to avoid ambiguity surrounding how the parameters get their values. Comments are used to avoid confusion with parameters that don't get their value directly from the manifest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit it becomes possible to build ACAP apps without installing the ACAP Native SDK. The functionality is enabled by setting
ACAP_BUILD_IMPL=equivalent. Note however that the sysroots are still needed e.g. to link with the ACAP Native SDK C APIs.