fix: Don't invalidate Cargo caches #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two root causes were identified: * Varying `RUSTFLAGS` * Always touching `bindings.rs` Varying `RUSTFLAGS` ------------------- When building for one of the non-host targets we set `RUSTFLAGS` to help the linker find the right sysroot. This also affects artifacts built for host in this invocation notably our build scripts and their dependencies. When building for host again, even if we don't build our build scripts, any mutual dependencies will see their caches invalidated causing some recompilation. By using one target dir for each set of flags the caches can be reused. Always touching `bindings.rs` ----------------------------- This caused recompilation only for `cargo doc`, presumably because the timestamp of one of the dependencies for the artifact being compiled had been updated. A small example that reproduces the problem is: ```sh cargo build -p acap-build cargo-acap-build --target aarch64 -- -p licensekey_handler cargo build -p acap-build ``` Background ---------- In an upcoming change I want to test that two different ways of producing EAP files are equivalent. To do so I want to build the apps twice but with different environment variables. Since all compilation should be cached I thought I could just run `make check_all` and `make check_generated_files_container` twice, but it turns out many artifacts are compiled again on the second run. Since running the tests on the second run is unnecessary I don't think I will use this approach, but being able to leverage the caches should make development faster. I'm not sure about the effect on CI though because I've seen indications that it is the build commands that are incompatible with each other and with each of the other commands for the other target.
apljungquist
added a commit
that referenced
this pull request
Nov 5, 2024
* upstream/main: (48 commits) chore: Use workspace dependencies consistently (#126) fix(axevent_example): Return `Break` from signal handlers (#125) chore(deps): bump ghcr.io/devcontainers/features/common-utils (#124) feat(device-manager): Allow unsigned ACAPs (#122) feat(acap-build): Enable bypassing `acap-build` (#119) chore: streamline CI (#118) fix: Don't invalidate Cargo caches (#117) fix(acap-ssh-utils): Warn users that commands may break (#114) feat: Factor out `acap-build` wrapper to lib crate (#112) feat: Add `fleet-manager` program (#111) feat: Add edge storage wrapper and example (#108) fix: Measure apparent size (#107) chore(acap-logging): Bump version (#106) fix(cargo-acap-sdk): Set executable bits (#105) fix(acap-logging)!: Disable default features for env_logger (#103) chore: Track size of apps (#102) chore: Don't use clearly defined for license info (#101) Update rust toolchain to 1.80.1 (#100) fix!: Make builds reproducible in dev-container (#99) feat(axevent)!: Use generic callbacks and remove leak (#59) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.