-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login screen: Rewritten from scratch #20
base: dev
Are you sure you want to change the base?
Conversation
Other changes: * Added menu style * Added menus to the document * Updated some styles
* Battery indicator * Brightness indicator * Keyboard layout indicator * Session indicator Other changes: * Updated login form * Minor UI changes * Added some session symbols/images
Other changes: * Minor UI changes * Updated some debug data
Other changes: * Minor UI changes
* Menus * Switcher * Lock screen (clock)
Other changes: * Updated Debug API * Minor UI fixes * Added some comments
* Use 2 spaces for an indent * Unconfilct files with PR's (maybe)
Other changes: * Minor UI fixes * Consistent formating
Will test this now. Can I ask which distro/system you are testing this on, and which parameters? |
I'm using Ubuntu 22.04 for main system and Arch Linux (latest) as testing machine (same as tester using) |
Power menu and keyboard layout functions work, everything else doesn't. When trying to log into a session, all fields and buttons get greyed out and the session hangs. Nothing happens. It causes a failure popup, the same as when you try to use the indicators for Brightness, Power and other things as well as switching sessions. I have attached the greeter log. |
Other changes: * Bug/error fixes * Updated debug API * Minor UI fixes * Added indicator availibility state * lightdm-webkit2-greeter (not web-greeter) compatiblity * Updated desktop entry file
I've fixed some errors, you can test it again. |
Other changes: * Updated images * Updated dbeug API * key event fixes
Other changes: * Minor UI fixes * Key event update
Other changes: * Minor UI fixes
This commit make user (probably) unhide the blank screen when user unidle and when computer is in sleep or hibernate (on restart computer)
avdanosLogin.log |
Suggestion: user-profile.png (the profile picture) should sync with the one you set in the OS itself, and there should be a way to change the background without command line. |
Other changes: * Updated debug api
Other changes: * Add background settings * Minor UI fixes
It is fixed, now you can try again. The battery and brightness for unsupported devices were already disabled programmatically and cannot be hidden because menus weren't reallocated properly. |
* Fixed timeout reached when authenticate on lightdm-webkit2-greeter * Added/enhanced auth messages to make more interactive login system * Removed autologin timer expired, since this login screen needs authentication before accessing to the desktop/session Other changes: * Minor UI fixes
Using lightdm.default_session is for getting default session from the vendor or organizations (i think)
@AdvendraDeswanta should this be merged? |
May be. Because enigmaPr0ject.tech authentication API does not work, why not use local authentication (standard login)? |
btw i think u have to use the dev branch not main |
It already used the dev branch not main. |
it seems like you are trying to merge from your repo:dev to this repo:main |
For Future Devs: And the testing needs to be done on Arch our testers usually install KDE first install my custom login screen (#20):
lightdm.conf, it's to set the lightdm engine (we use lightdm-webkit2-greeter) and on lightdm-webkit2-greeter.conf, it's to set the theme (we use avdanos theme) don't forget to set secure_mode to false on lightdm-webkit2-greeter.conf |
Yep disable the API login system (not sure why it was used in first place) and replace with normal local authentication |
Do we need the images in /img/sessions? Since this login screen will be used with AvdanOS, I don't think we need to include assets of other desktop environments. |
Hmm I assume you mean avdanos-desktop/lightdm-avdanos-theme/img/sessions/i3-with-shmlog.png |
Yes, the images in that directory like the i3 image you have provided the path for. |
hmm true |
Brightness Is Not Working On My Laptop |
Testing in VM or dualboot etc? |
Since the API Authentication was inactive or dead, we will use standard login as normal authentication, also this login screen includes the slider user switching, tell me for user switching system changes.
I rember about this, I'm going to try it on my laptop this afternoon and send feedback |
I've rewritten the login screen with a few files and take a bit of reference from the current one.
Some elements need to be worked/usable (checked for done):
and some tests:
*Some testers if you have a laptop, please test it for brightness controller (DO NOT USE VM)
NOTE: Please do some tests before merging this PR and use
web-greeter
(instead oflightdm-webkit2-greeter
) to test the login screenHow to test:
This will set the
greeter-session
(default greeter session) toweb-greeter
This will set the
webkit_theme
(default greeter theme) to this themeavdanos
and also set thesafe_mode
tofalse
to prevent blocking API requests (but for now, the API won't be working, so it's optional)These items will be fixed/added/checked for the following commits.