Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Fix life cycle warnings #159

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ChicaoDev
Copy link

No description provided.

@netlify
Copy link

netlify bot commented Oct 30, 2019

Deploy preview for availity-reactstrap-validation ready!

Built with commit 05764f8

https://deploy-preview-159--availity-reactstrap-validation.netlify.com

@TheSharpieOne
Copy link
Collaborator

This change requires a change to the minimum react and react-dom versions since the UNSAFE_ methods are new(er).
If you check out the preview, you'll see that nothing works.

@robmcguinness robmcguinness added the breaking change Changes that would require major version bump to library label Dec 10, 2019
@mrsarm
Copy link

mrsarm commented Apr 30, 2020

I cannot wait until this is published, for a project that it's in bootstrapping phase in a professional environment it's hard to explain to your architect leader or just your team leader why you chose to use a library that triggers warnings on each view of the application, it makes the library to look outdated and wrong, so for everybody with the same issue than me, here is a fork that solves the issue: https://www.npmjs.com/package/availity-reactstrap-validation-safe

@mistysmilesalot
Copy link

@Murzbul @sublimedatasys @yafimsva Is this ever going to make it in to the package?

Copy link
Contributor

@nikkhielseath nikkhielseath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings,

I actually won't consider this a fix.
The title should be changed to say "Suppress" Life Cycle Warnings.

That said, I am grateful that you spent time and made the much required changes. :)

Regards
SNikhill

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change Changes that would require major version bump to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants