Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New encoder #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

New encoder #2

wants to merge 3 commits into from

Conversation

pequeno212
Copy link
Contributor

For Ben to look at

Copy link
Contributor

@benjamin-owen benjamin-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple things I notice:

  • You have a net for "V+" going into the op-amps, but that isn't connected anywhere.
  • Connector for the VESC (JST connector) isn't marked correctly. This isn't the same as the input connector, so you will need to check the VESC manual to find the correct pins that are used. We will only have a few of the pins populated (I think ADC1, ADC2, and ground)
  • A few of the PCB components could be placed more efficiently. The first thing I noticed was R1/R2 forcing overlapping traces when they could simply be flipped placement wise to fix.
  • Watch for the part labels overlapping with copper. You can move the part labels individually and move them out of the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants