This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Kart commander #46
Open
Reschivon
wants to merge
34
commits into
main
Choose a base branch
from
kart_commander
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Kart commander #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Added QoS profile and state transition rules
in hindsight it was simpler. If one mux fails both are likely screwed
See the AKS server for the state graph
It was using the rcs_service package before
No documentation for constants needed some trial n error
tests to be made automated later, see readme in tests
the new `switching_mux` let through one topic at a time
remove debug logger line
install-scripts to install_scripts
script_dir with an underscore
they were causing ci to fail
@alanssitis approve this |
Will test right now. Will add changes that may be needed in a review. |
sg |
for more information, see https://pre-commit.ci
Added QoS profile and state transition rules
in hindsight it was simpler. If one mux fails both are likely screwed
See the AKS server for the state graph
It was using the rcs_service package before
No documentation for constants needed some trial n error
tests to be made automated later, see readme in tests
the new `switching_mux` let through one topic at a time
remove debug logger line
install-scripts to install_scripts
script_dir with an underscore
they were causing ci to fail
alanssitis
force-pushed
the
kart_commander
branch
from
May 11, 2023 20:12
341b0fa
to
2db155a
Compare
Just rebased. |
changed msgs package lost in rebase
alanssitis
previously requested changes
May 12, 2023
also, fill out package xml with your info and fill TODOs |
renamed it in rcs too
added metadat to package.xml
…rdue/AMP_ASSV3 into kart_commander
add license to package.xml
modified the mqtt node
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description
Kart Commander and Mux for Twist messages
Related Issues
Closes ...
Opens ...
Details
Tasks