Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sites Dashboard: Remove more unnecessary DataViews style overrides #96717

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Sites Dashboard: Remove more unnecessary DataViews style overrides #96717

merged 1 commit into from
Nov 25, 2024
+2 −96

Conversation

okmttdhr
Copy link
Member

@okmttdhr okmttdhr commented Nov 25, 2024 •
edited
Loading

Related to https://github.com/Automattic/dotcom-forge/issues/9915

Proposed Changes

This PR removes more DataViews style overrides.

  • Most of the overrides removed in this PR were no longer necessary.
  • Some overrides do not apply to Sites Dashboard.
production this PR (no changes)
Screenshot 2024-11-25 at 16 31 16 Screenshot 2024-11-25 at 16 31 28

Why are these changes being made?

pbxlJb-6DF-p2

Testing Instructions

  • Go to /sites.
  • Ensure that no significant visual or functional regressions are introduced.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@okmttdhr okmttdhr changed the title Remove more unnecessary DataViews overrides Remove more unnecessary DataViews style overrides Nov 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125557
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125557&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125557&env=a8c-for-agencies

@okmttdhr okmttdhr changed the title Remove more unnecessary DataViews style overrides Sites Dashboard: Remove more unnecessary DataViews style overrides Nov 25, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/remove-dataview-overrides on your sandbox.

okmttdhr
okmttdhr commented Nov 25, 2024
View reviewed changes
client/sites/components/sites-dataviews/dataview-style.scss
thead .dataviews-view-table__row th {
span,
button {
font-size: rem(11px);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR removes the use of rem for font sizes. I'm curious if the theming APIs mentioned in pbxlJb-6A9-p2#comment-4011 would address font sizing as well. IMO, it would be so great if we have it! @oandregal @ciampo

client/sites/components/sites-dataviews/dataview-style.scss
th {
border-bottom: 1px solid var(--color-neutral-5);
font-size: rem(13px);
font-weight: 400;
vertical-align: middle;
Copy link
Member Author

@okmttdhr okmttdhr Nov 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll address this vertical-align: middle in a separate PR.

@okmttdhr okmttdhr marked this pull request as ready for review November 25, 2024 07:38
@okmttdhr okmttdhr self-assigned this Nov 25, 2024
@okmttdhr okmttdhr requested a review from a team November 25, 2024 07:39
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 25, 2024
fushar
fushar approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried on several resolution, didn't notice any regression 👍

@okmttdhr okmttdhr merged commit 2da93a9 into trunk Nov 25, 2024
18 of 19 checks passed
@okmttdhr okmttdhr deleted the update/remove-dataview-overrides branch November 25, 2024 08:02
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fushar fushar fushar approved these changes

Assignees

@okmttdhr okmttdhr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@okmttdhr @matticbot @fushar