Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untangling: polish UI components of the new IA #96711

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Conversation

fushar
Copy link
Contributor

@fushar fushar commented Nov 25, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/9865

Proposed Changes

This PR does the following:

Note

Sorry for the large number of changed files; it's mostly import changes 😭

Why are these changes being made?

pbxlJb-6ye-p2

Testing Instructions

  1. Go to /sites.
  2. Click a site.
  3. Click around the subtabs and verify there are no visual issues.
  4. Try with several site types.
  5. Test also with ?flags=-untangling/hosting-menu flag turned offf.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Nov 25, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~252 bytes added 📈 [gzipped])

name                parsed_size           gzip_size
site-tools              +1058 B  (+0.1%)     +269 B  (+0.1%)
github-deployments       +881 B  (+0.1%)     +173 B  (+0.0%)
staging-site             +131 B  (+0.0%)      +30 B  (+0.0%)
hosting                  +130 B  (+0.0%)      +24 B  (+0.0%)
site-marketing            +93 B  (+0.0%)       -5 B  (-0.0%)
site-settings             -57 B  (-0.0%)       -9 B  (-0.0%)
settings                  -30 B  (-0.0%)      -41 B  (-0.0%)
marketing                 +17 B  (+0.0%)       -6 B  (-0.0%)
jetpack-social            +13 B  (+0.0%)       -2 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~23 bytes added 📈 [gzipped])

name                                       parsed_size           gzip_size
async-load-calypso-layout-command-palette        +70 B  (+0.0%)      +23 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Nov 25, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug untangling/polish-ui on your sandbox.

@fushar fushar self-assigned this Nov 25, 2024
@fushar fushar marked this pull request as ready for review November 25, 2024 06:18
@fushar fushar requested a review from a team November 25, 2024 07:00
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 25, 2024
Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested around a LGTM 👍
I found an issue with the Marketing tab width on small screens, not sure if it's related to this but I didn't see the issue in wpcalypso.

Screenshot 2024-11-25 at 3 19 43 PM

@fushar fushar merged commit fdaf7c6 into trunk Nov 25, 2024
11 checks passed
@fushar fushar deleted the untangling/polish-ui branch November 25, 2024 10:13
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants