Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PayPal: update key for PayPal Express assignment processor #96703

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

michaeldcain
Copy link
Member

In #94790, we updated the PayPal Express payment method ID to paypal-express to allow simultaneous testing of PayPal Express and PPCP payment methods. The same key is also used as the paymentProcessorId to pair a processor to a payment method, and while we updated the processor list for Checkout, we missed the processor list for the manage purchase screens.

This updates the manage purchase processor list to use the correct paypal-express key.

Reported: p1732399559650689-slack-C02BEP610

To test:

  • visit Me > Upgrades and select an existing purchase
  • click "Add/Change payment method"
  • select PayPal from the methods and input a country and zipcode
  • click the PayPal button
  • verify that you're redirected to PayPal

@michaeldcain michaeldcain self-assigned this Nov 24, 2024
@michaeldcain michaeldcain requested a review from a team as a code owner November 24, 2024 03:39
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 24, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@michaeldcain michaeldcain merged commit 5e35dc3 into trunk Nov 24, 2024
14 of 15 checks passed
@michaeldcain michaeldcain deleted the update/paypal-express-assign-processor-key branch November 24, 2024 03:40
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 24, 2024
@sirbrillig
Copy link
Member

Oops. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants