Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment Methods: enable PPCP method in all environments except test and production #96692

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

michaeldcain
Copy link
Member

@michaeldcain michaeldcain commented Nov 22, 2024

After D165065-code was merged, we started gating the availability of the new PayPal PPCP payment method through the backend (via the shopping cart's allowed_payment_methods and the /me/allowed-payment-methods endpoint). This means that we no longer need to gate the PayPal JS availability via Calypso environment configs.

To enable easier testing of the new payment method, this PR sets the config flag to true in all but the test and production environments. Thus based on the result of the backend's is_paypal_ppcp_enabled(), we'll be able to control which PayPal payment method is available. I left the flags in production and test environments just as a safety precaution.

I've also added a temporary (PPCP) to the new payment method selector to help testers know which method they're using.

Screenshot 2024-11-23 at 7 42 47 AM

To test:
A visual check should suffice, but you can also verify that WPCOM_Billing_PayPal_PPCP or WPCOM_Billing_PayPal_Express is available/unavailable via the shopping cart endpoint based on the configs in D167015-code.

@michaeldcain michaeldcain self-assigned this Nov 22, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 22, 2024
@michaeldcain michaeldcain added Payment Methods and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 22, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 22, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@michaeldcain
Copy link
Member Author

Sort of a duplicate of #96682

@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 22, 2024
@michaeldcain michaeldcain reopened this Nov 23, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 23, 2024
@michaeldcain michaeldcain force-pushed the update/paypal-ppcp-enabled-environments branch from 711d2ef to bf9b45c Compare November 23, 2024 12:39
@michaeldcain michaeldcain requested a review from a team as a code owner November 23, 2024 12:43
@matticbot
Copy link
Contributor

matticbot commented Nov 23, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/paypal-ppcp-enabled-environments on your sandbox.

@michaeldcain michaeldcain merged commit 7e5f54c into trunk Nov 23, 2024
13 checks passed
@michaeldcain michaeldcain deleted the update/paypal-ppcp-enabled-environments branch November 23, 2024 14:28
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants