Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: Prevent premium domain names suggestion/selection for all 100-year flows #96550

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

rafaelgallani
Copy link
Contributor

Proposed Changes

Prevents premium domain names suggestion/selection for all 100-year related flows.

Testing Instructions

  • Build this branch locally or access its calypso.live link;
  • Go to any 100-year related flow (100-year plan, 100-year domain, e.g. /setup/hundred-year-domain/domains);
  • Try entering a premium domain name (e.g. meat.blog) and ensure you see the same error message as in the screenshot below.

Preview

Before After
image image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@rafaelgallani rafaelgallani self-assigned this Nov 19, 2024
@rafaelgallani rafaelgallani requested a review from a team as a code owner November 19, 2024 17:43
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 19, 2024
@matticbot
Copy link
Contributor

matticbot commented Nov 19, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~80 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
update-design-flow         +427 B  (+0.0%)      +80 B  (+0.0%)
link-in-bio-tld-flow       +427 B  (+0.0%)      +80 B  (+0.0%)
domains                    +427 B  (+0.0%)      +80 B  (+0.0%)
copy-site-flow             +427 B  (+0.1%)      +80 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~80 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
async-load-signup-steps-domains       +427 B  (+0.1%)      +80 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@leonardost leonardost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM! Thanks for this fix!

client/components/domains/register-domain-step/index.jsx Outdated Show resolved Hide resolved
@rafaelgallani
Copy link
Contributor Author

Rebasing on trunk so the checks can pass correctly.

@rafaelgallani rafaelgallani force-pushed the fix/premium-domain-names-on-100-year-domain branch from d18085b to 53fd054 Compare November 19, 2024 21:05
@rafaelgallani rafaelgallani merged commit ee07e8d into trunk Nov 19, 2024
10 of 11 checks passed
@rafaelgallani rafaelgallani deleted the fix/premium-domain-names-on-100-year-domain branch November 19, 2024 22:34
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 19, 2024
@a8ci18n
Copy link

a8ci18n commented Nov 19, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17009265

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @rafaelgallani for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Nov 24, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants