Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Make header on traffic page sticky #96532

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

annacmc
Copy link
Contributor

@annacmc annacmc commented Nov 19, 2024

Related to https://github.com/Automattic/red-team/issues/217

Proposed Changes

  • Makes the header on the traffic page sticky

Why are these changes being made?

  • Part of the Date filtering for the traffic page project (header refresh section)

Testing Instructions

  • Open the Calypso Live link.
  • Visit the Stats → Traffic page and confirm it loads normally.
  • Manually enable the feature flag: ?flags=stats/new-date-filtering
  • Scroll the page and confirm the header sticks to the top of the page.
  • Keep an eye out for unintended layout changes.
Design Image Screenshot from branch
image image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@annacmc annacmc force-pushed the update/stats-sticky-header-component branch from e0e4343 to 6da9970 Compare November 19, 2024 11:20
@matticbot
Copy link
Contributor

matticbot commented Nov 19, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stats-sticky-header-component on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Nov 19, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1031 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats      +3987 B  (+0.4%)    +1031 B  (+0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@annacmc annacmc added the Stats Everything related to our analytics product at /stats/ label Nov 24, 2024
@annacmc annacmc self-assigned this Nov 24, 2024
@annacmc annacmc force-pushed the update/stats-sticky-header-component branch from 3055312 to be13644 Compare November 25, 2024 00:23
@annacmc annacmc marked this pull request as ready for review November 25, 2024 01:00
@annacmc annacmc requested a review from a team November 25, 2024 01:00
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 25, 2024
@annacmc annacmc changed the title Update/stats sticky header component Stats: Make header on traffic page sticky Nov 25, 2024
Copy link
Contributor

@kangzj kangzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship first and iteration cuz it looks mostly good to me!

@kangzj kangzj merged commit 872fb2c into trunk Nov 25, 2024
15 checks passed
@kangzj kangzj deleted the update/stats-sticky-header-component branch November 25, 2024 02:01
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants