Add status caching to two core hacks filters

Automattic · Oct 14, 2024 · 0ee148e · 0ee148e
1 parent 703072e
commit 0ee148e
Showing 1 changed file with 14 additions and 3 deletions.
diff --git a/modules/shared/php/core-hacks.php b/modules/shared/php/core-hacks.php
@@ -117,8 +117,13 @@ public static function fix_preview_link_part_one( string $preview_link ): string
 
 		$post = get_post( get_the_ID() );
 
-		// Only modify if we're using a pre-publish status on a supported custom post type
-		$status_slugs = wp_list_pluck( CustomStatus::get_custom_statuses(), 'slug' );
+		// Optimization: preview_post_link is called for each visible post on the Posts -> All Posts page.
+		// Temporarily cache slugs to avoid calling get_custom_statuses() for each post.
+		static $status_slugs = false;
+		if ( false === $status_slugs ) {
+			$status_slugs = wp_list_pluck( CustomStatus::get_custom_statuses(), 'slug' );
+		}
+
 		if ( ! $post
 		|| ! is_admin()
 		|| 'post.php' != $pagenow
@@ -360,8 +365,14 @@ private static function get_preview_link( WP_Post $post ): string {
 	public static function fix_post_row_actions( array $actions, WP_Post $post ): array {
 		global $pagenow;
 
+		// Optimization: fix_post_row_actions is called for each visible post on the Posts -> All Posts page.
+		// Temporarily cache slugs to avoid calling get_custom_statuses() for each post.
+		static $status_slugs = false;
+		if ( false === $status_slugs ) {
+			$status_slugs = wp_list_pluck( CustomStatus::get_custom_statuses(), 'slug' );
+		}
+
 		// Only modify if we're using a pre-publish status on a supported custom post type
-		$status_slugs = wp_list_pluck( CustomStatus::get_custom_statuses(), 'slug' );
 		if ( 'edit.php' != $pagenow
 		|| ! in_array( $post->post_status, $status_slugs )
 		|| ! in_array( $post->post_type, HelperUtilities::get_supported_post_types() ) ) {