Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Assembler typography styles #8421

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Conversation

richtabor
Copy link
Contributor

@richtabor richtabor commented Nov 15, 2024

A few improvements I discovered as I research what folks are doing with the Assembler theme.

Changes proposed in this Pull Request:

Site tagline

CleanShot.2024-11-15.at.16.40.47.mp4

H4 Before

CleanShot 2024-11-15 at 15 54 33

H4 After

CleanShot 2024-11-15 at 15 54 01

@richtabor richtabor self-assigned this Nov 15, 2024
Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Assembler.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@alaczek
Copy link
Contributor

alaczek commented Nov 19, 2024

This is looking good to me, but we should also address these two things:

  • in the 05-fahkwang.json the headings are supposed to use 200 font weight, but we only register 400 and 600.
  • in 01-figtree.json the headings are supposed to use 900 font weight, but we only register 400-700.

We either need to add the missing font weights or update the headings definition.

There are also unused fonts - Libre Baskerville, and Rufina.

Copy link
Contributor

Theme-Check results

assembler: No changes required ✅.


Copy link
Contributor

Theme-Check results

assembler: No changes required ✅.


@richtabor
Copy link
Contributor Author

We either need to add the missing font weights or update the headings definition.

There are also unused fonts - Libre Baskerville, and Rufina.

Addressed, thanks!

Copy link
Contributor

@alaczek alaczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alaczek alaczek merged commit bbc54c6 into trunk Nov 21, 2024
3 checks passed
@alaczek alaczek deleted the improve/assembler-typography branch November 21, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants