-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Assembler typography styles #8421
Conversation
Preview changesI've detected changes to the following themes in this PR: Assembler. I will update this comment with the latest preview links as you push more changes to this PR. Note The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions. |
This is looking good to me, but we should also address these two things:
We either need to add the missing font weights or update the headings definition. There are also unused fonts - Libre Baskerville, and Rufina. |
Theme-Check resultsassembler: No changes required ✅. |
Theme-Check resultsassembler: No changes required ✅. |
Addressed, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
A few improvements I discovered as I research what folks are doing with the Assembler theme.
Changes proposed in this Pull Request:
xx-large
just a little.Site tagline
CleanShot.2024-11-15.at.16.40.47.mp4
H4 Before
H4 After