Prevent early translation loading #7701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test the previous changes of this PR with WordPress Playground. |
|
Test the previous changes of this PR with WordPress Playground. |
|
Test the previous changes of this PR with WordPress Playground. |
|
Test the previous changes of this PR with WordPress Playground. |
m1r0
force-pushed
the
fix/early-translations
branch
from
b951a2c
to
77ee8c5
Compare
|
Test the previous changes of this PR with WordPress Playground. |
m1r0
force-pushed
the
fix/early-translations
branch
from
77ee8c5
to
077f563
Compare
|
Test the previous changes of this PR with WordPress Playground. |
m1r0
force-pushed
the
fix/early-translations
branch
from
077f563
to
7cc134a
Compare
|
Test the previous changes of this PR with WordPress Playground. |
m1r0
commented
Nov 5, 2024
Comment on lines
+35
to
+39
| <referencedProperty name="Sensei_PostTypes::$course" /> | ||
| <referencedProperty name="Sensei_PostTypes::$lesson" /> | ||
| <referencedProperty name="Sensei_PostTypes::$question" /> | ||
| <referencedProperty name="Sensei_PostTypes::$quiz" /> | ||
| <referencedProperty name="Sensei_PostTypes::$messages" /> |
There was a problem hiding this comment.
This is needed because the constructor properties are set dynamically.
donnapep
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7696
Proposed Changes
There is a new change in WordPress 6.7 that prevents plugins from loading translations too early, without waiting for more parts of WordPress to be loaded.
This PR fixes all translations that are loaded early while preserving the code logic.
Testing Instructions
PHP Notice: Function _load_textdomain_just_in_time was called incorrectlyPre-Merge Checklist