Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GitHub Actions workflow for code coverage #7679

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

donnapep
Copy link
Collaborator

@donnapep donnapep commented Sep 6, 2024

We need to speed up our CI and the PHP & JavaScript Code Coverage report takes too long to run and is of little value to our existing processes.

Proposed Changes

  • Don't run the code coverage job as part of CI.
  • You can still run npm run test-js:coverage locally.

Testing Instructions

Ensure that the PHP & JavaScript Code Coverage job doesn't run on this pull request.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Legacy courses (course without blocks) are tested
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

We need to speed up our CI and this report doesn't have much value.
@donnapep donnapep added this to the 4.24.4 milestone Sep 6, 2024
@donnapep donnapep self-assigned this Sep 6, 2024
@donnapep donnapep changed the title Remove GitHub Actions workflow for coverage reports Remove GitHub Actions workflow for code coverage Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

Test the previous changes of this PR with WordPress Playground.

@donnapep donnapep merged commit bc95e04 into trunk Sep 6, 2024
24 of 25 checks passed
@donnapep donnapep deleted the remove/code-coverage-github-action branch September 6, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant