Add hook to conditionally show the lesson actions block in the frontend #7677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test the previous changes of this PR with WordPress Playground. |
donnapep
reviewed
Sep 5, 2024
| @@ -1358,6 +1358,21 @@ public function testShouldShowLessonActions_WhenPrerequisiteFoundAndWasNotLesson | |||
| self::assertFalse( $result ); | |||
| } | |||
|
|
|||
| public function testShouldShowLessonActions_WhenHookSetsFalce_ReturnsFalse(): void { | |||
There was a problem hiding this comment.
This test case name is somewhat misleading. In particular, the WhenHookSetsFalse part because in this test case we're testing both true and false. We could split these into 2 separate use cases to test each since there isn't much repetitive setup code.
donnapep
previously approved these changes
Sep 5, 2024
|
Test the previous changes of this PR with WordPress Playground. |
|
Test the previous changes of this PR with WordPress Playground. |
|
Test the previous changes of this PR with WordPress Playground. |
|
Test the previous changes of this PR with WordPress Playground. |
|
Test the previous changes of this PR with WordPress Playground. |
|
Test the previous changes of this PR with WordPress Playground. |
Imran92
deleted the
fix/prevent-rendering-lesson-actions-in-content-drip
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/Automattic/sensei-pro/issues/1956 (partial)
Proposed Changes
We've added a hook here which will allow us to conditionally render the lesson actions block in the frontend from elsewhere (i.e. Sensei-pro)
Testing Instructions
New/Updated Hooks
Pre-Merge Checklist