Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP deprecation notice about passing null to parameter of type st… #7668

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

donnapep
Copy link
Collaborator

@donnapep donnapep commented Aug 16, 2024

Proposed Changes

Fixes a deprecation notice:

PHP Deprecated:  parse_str(): Passing null to parameter #1 ($string) of type string is deprecated in /Users/donnapep/Local Sites/senseitheme/app/public/wp-content/plugins/sensei/includes/class-sensei-utils.php on line 2921

Testing Instructions

  1. Ensure you're using PHP 8.1+.
  2. Go to Appearance > Editor.
  3. Ensure the above deprecation notice is not logged.

Note that the following PHP warnings are still logged, but this PR does not attempt to fix those:

PHP Warning:  Undefined property: stdClass::$modified in /Users/donnapep/Local Sites/senseitheme/app/public/wp-includes/rest-api/endpoints/class-wp-rest-templates-controller.php on line 766
PHP Warning:  DOMDocument::loadHTML(): Unexpected end tag : p in Entity, line: 1 in /Users/donnapep/Local Sites/senseitheme/app/public/wp-content/plugins/sensei/includes/blocks/class-sensei-blocks.php on line 225

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Legacy courses (course without blocks) are tested
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@donnapep donnapep added this to the 4.24.3 milestone Aug 16, 2024
@donnapep donnapep self-assigned this Aug 16, 2024
Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link

Test the previous changes of this PR with WordPress Playground.

@donnapep donnapep merged commit ed5e840 into trunk Aug 19, 2024
23 checks passed
@donnapep donnapep deleted the fix/php-deprecations-and-warnings branch August 19, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant