Site Scan & AMP: Include toolbar scripts for Site Scan have data-ampdevmode on AMP requests #17034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an automated check which relies on E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17034 |
westonruter
commented
Sep 1, 2020
jeherve
added
[Type] Bug
jeherve
added
[Pri] Normal
[Status] Needs Review
jeherve
added
[Status] Ready to Merge
jeherve
approved these changes
Sep 2, 2020
rcanepa
approved these changes
Sep 2, 2020
matticbot
added
[Status] Needs Changelog
and removed
[Status] Ready to Merge
davidlonjon
added a commit
that referenced
this pull request
Sep 4, 2020
* master: External Media: Handle space errors on upload (#17014) Autoloader: Support unoptimized PSR-4 (#16819) Donations / Payments: Use getSiteFragment for building Calypso links (#17042) Site Scan & AMP: Include toolbar scripts for Site Scan have data-ampdevmode on AMP requests (#17034) Update optin comment to correct default value of true. (#17048) Plugins: avoid including network-activated plugins in responses (#17044) Instant Search: Fix photon integration (#17037)
pereirinha
pushed a commit
that referenced
this pull request
Sep 10, 2020
… have data-ampdevmode on AMP requests (#17034)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the Site Scan feature launched, I've very frequently seen the AMP menu item in the admin bar show validation errors:
The validation errors are coming from Jetpack:
Specifically they are coming from the Site Scan feature:
The issue can be fixed simply be flagging the scripts as being part of AMP Dev Mode.
This can be done for the
jetpack-scan-show-noticescript simply by making it dependent on theadmin-barscript, which is itself already part of AMP Dev Mode by default. The only thing left is to ensure that the inline script (added viawp_localize_script()) to also be flagged for AMP Dev Mode via theamp_dev_mode_element_xpathsfilter, which itself may be unnecessary after ampproject/amp-wp#4598.Changes proposed in this Pull Request:
data-ampdevmodeattributes to printed scripts for Site Scan toolbar.Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Proposed changelog entry for your changes: