Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automattic for Agencies: Add support for the newly added A4A Calypso live link environment #224

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented Mar 1, 2024

Background

To test the changes done to the newly added environment for Automattic for Agencies on Calypso live links, we need to update the environments here to support that environment.

Changes

This PR

  • Adds a8c-for-agencies to the envs in the src/config.ts file.
  • Adds a new case to the switch statement for a8c-for-agencies that returns Env resolving NODE_ENV and CALYPSO_ENV to a8c-for-agencies-horizon.

Testing

  • Check out this branch and start dserve (it may take a while to update the wp-calypso repo).
  • Go to the URL specified in 33ce4-pb/#plain > It should download the image > Verify that you are redirected to Calypso (Automattic for Agencies). Please ignore the empty page.
Screenshot 2024-03-12 at 5 38 24 PM

@yashwin yashwin self-assigned this Mar 1, 2024
@yashwin yashwin marked this pull request as draft March 1, 2024 09:21
@yashwin yashwin marked this pull request as ready for review March 12, 2024 12:10
@yashwin yashwin changed the title Add A4A Environment Automattic for Agencies: Add support for the newly added A4A Calypso live link environment Mar 12, 2024
@yashwin yashwin requested a review from a team March 12, 2024 12:32
@yashwin
Copy link
Contributor Author

yashwin commented Mar 12, 2024

I see the Circle CI build is failing here. Appreciate any help on this. Thanks!

@nb nb requested review from a team and removed request for a team March 13, 2024 08:16
Copy link
Member

@jsnajdr jsnajdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It's also the kind of PR that didn't really need review.

@yashwin
Copy link
Contributor Author

yashwin commented Mar 14, 2024

Thanks, @jsnajdr!

@jsnajdr jsnajdr force-pushed the add/a4a-environment branch from 9618004 to 06e8d7f Compare March 14, 2024 08:14
@jsnajdr
Copy link
Member

jsnajdr commented Mar 14, 2024

The CircleCI check is green now 🙂 It was failing because SSH keys used by CircleCI to checkout code from GitHub were no longer working for some reason. I was able to fix it simply by removing the project from CircleCI and then adding it again.

One other thing I tried is to upgrade the testing CircleCI Docker image from the legacy circleci/node:10 to the recent cimg/node:20.11.0, in #225, but that will require more work. Currently yarn install is failing there, failing to build some packages.

@yashwin yashwin merged commit 3299cd4 into master Mar 15, 2024
1 check passed
@yashwin yashwin deleted the add/a4a-environment branch March 15, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants