Skip to content

Commit

Permalink
Merge pull request #159 from Automattic/update/upgrade-node-latest-lts
Browse files Browse the repository at this point in the history
Upgrade to node 12.16.3
  • Loading branch information
scinos authored May 4, 2020
2 parents edad41d + b004d8b commit 75cfb93
Show file tree
Hide file tree
Showing 5 changed files with 170 additions and 135 deletions.
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v10.15.0
v12.16.3
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"@types/lodash": "^4.14.116",
"@types/node": "^10.12.2",
"@types/node-fetch": "^2.1.2",
"@types/nodegit": "^0.22.4",
"@types/nodegit": "^0.26.2",
"@types/react": "^16.4.8",
"@types/react-dom": "^16.0.7",
"@types/strip-ansi": "^3.0.0",
Expand All @@ -36,7 +36,7 @@
"jest": "^24.0.0",
"lodash": "^4.17.10",
"node-fetch": "^2.2.1",
"nodegit": "^0.23.0",
"nodegit": "^0.26.5",
"portfinder": "^1.0.16",
"react": "^16.4.2",
"react-dom": "^16.4.2",
Expand Down
3 changes: 1 addition & 2 deletions src/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ async function getRemoteBranches(): Promise< Map< string, string > > {
timing( 'git.refresh', Date.now() - start );

try {
const branchesReferences = ( await repo.getReferences( git.Reference.TYPE.OID ) ).filter(
const branchesReferences = (await repo.getReferences( )).filter(
( x: git.Reference ) => x.isBranch
);

Expand All @@ -309,7 +309,6 @@ async function getRemoteBranches(): Promise< Map< string, string > > {
} )
);

repo.free();
// gc the repo if no builds are running
if ( pendingHashes.size === 0 ) {
try {
Expand Down
3 changes: 0 additions & 3 deletions src/builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,6 @@ async function waitForCommit( commitHash: CommitHash ): Promise< boolean > {
} catch {
return false;
}
} finally {
repo.free();
}
}

Expand Down Expand Up @@ -164,7 +162,6 @@ export async function buildImageForHash( commitHash: CommitHash ): Promise< void
const commit = await repo.getCommit( commitHash );
const branch = await repo.createBranch( 'dserve', commit, true );
await repo.checkoutBranch( branch );
repo.free();
const checkoutTime = Date.now() - checkoutStart;
timing( 'git.build.checkout', checkoutTime );
l.log( { commitHash, checkoutTime }, 'Checked out branch' );
Expand Down
Loading

0 comments on commit 75cfb93

Please sign in to comment.