Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only load editor script if block editor #2837

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Only load editor script if block editor #2837

merged 1 commit into from
Jul 29, 2024

Conversation

yscik
Copy link
Contributor

@yscik yscik commented Jul 22, 2024 •
edited by github-actions bot
Loading

Fixes #2830

Changes Proposed in this Pull Request

  • Don't load the job tags upsell script if the current screen is not a block editor

Testing Instructions

  • Activate the Classic editor plugin
  • Edit a job listing
  • Check that there is no JS error in the console

Release Notes

  • Fix classic editor support for job listings
Plugin build for a4f4e4c
📦 Download plugin zip
▶️ Open in playground

@yscik yscik added this to the 2.4.0 milestone Jul 22, 2024
@yscik yscik self-assigned this Jul 25, 2024
@yscik yscik requested a review from a team July 25, 2024 09:01
mikeyarce
mikeyarce approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@mikeyarce mikeyarce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Classic Editor and fixes the issue ✅

@yscik yscik merged commit a75691e into trunk Jul 29, 2024
12 checks passed
@yscik yscik deleted the fix/job-tags-script-classic-editor branch July 29, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeyarce mikeyarce mikeyarce approved these changes

Assignees

@yscik yscik

Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

Job Tags Upsell Error
2 participants
@yscik @mikeyarce