Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop IE11 support from scripts build #2835

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Drop IE11 support from scripts build #2835

merged 1 commit into from
Jul 25, 2024

Conversation

yscik
Copy link
Contributor

@yscik yscik commented Jul 22, 2024 •
edited by github-actions bot
Loading

Fixes #2834

Changes Proposed in this Pull Request

  • Remove custom list of browser targets and use the WordPress default
  • This effectively removes IE11 from the supported browsers

Testing Instructions

  • Build the scripts with npm run build:assets
  • Use WordPress 6.6 on a test site
  • Visit the job listing admin page, and check that there are no console errors
  • Enable stats
  • Visit a job listing, and check that there are no console errors and the stat request is sent

Release Notes

  • Remove support for Internet Explorer 11
  • Fix Wordpress 6.6 compatibility

New or Updated Hooks and Templates

Plugin build for 4809257
📦 Download plugin zip
▶️ Open in playground

@yscik yscik requested a review from a team July 22, 2024 15:26
@yscik yscik added this to the 2.4.0 milestone Jul 22, 2024
thedebian
thedebian approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@thedebian thedebian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well 🚀

@yscik yscik merged commit 1bed471 into trunk Jul 25, 2024
12 checks passed
@yscik yscik deleted the fix/babel-error branch July 25, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedebian thedebian thedebian approved these changes

Assignees

@yscik yscik

Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

Typescript error in console
2 participants
@yscik @thedebian