Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "addons" to "marketplace" on the UI and URL #2622

Merged
merged 10 commits into from
Oct 31, 2023
Merged

Rename "addons" to "marketplace" on the UI and URL #2622

merged 10 commits into from
Oct 31, 2023

Conversation

fjorgemota
Copy link
Member

@fjorgemota fjorgemota commented Oct 16, 2023 •
edited by github-actions bot
Loading

Fixes #2616

Changes Proposed in this Pull Request

  • Change every URL and UI reference from "add-ons" to "marketplace" (or "extensions", where appropriate)
    • This change doesn't change any filenames, classes, method, functions or hook names

Testing Instructions

Navigate WPJM and make sure all links to the previous addons page still works correctly. Check notices and various possible references to the pages.

Release Notes

  • Use "extensions" instead of "add-ons" on the URLs and UI

Screenshot / Video

Plugin build for 67a7b6f
📦 Download plugin zip
▶️ Open in playground

@fjorgemota fjorgemota self-assigned this Oct 16, 2023
@fjorgemota fjorgemota force-pushed the change/rename-addons-to-marketplace branch from e11b7f3 to d0c7d38 Compare October 17, 2023 22:24
@fjorgemota fjorgemota requested a review from a team October 17, 2023 22:28
@fjorgemota fjorgemota marked this pull request as ready for review October 17, 2023 22:28
@fjorgemota fjorgemota linked an issue Oct 17, 2023 that may be closed by this pull request
Rename references from "add-on" to "Marketplace" #2616
Closed
@fjorgemota fjorgemota changed the title Rename "addons" page to "marketplace" Rename "addons" to "marketplace" on the UI and URL Oct 17, 2023
yscik
yscik approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@yscik yscik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

A worry I thought of is will people find the "Licenses" page under "Marketplace". But we do link to it directly so it's probably fine.

includes/admin/views/html-admin-page-addons.php Show resolved Hide resolved
readme.txt Outdated Show resolved Hide resolved
@fjorgemota
Copy link
Member Author

@yscik Thanks for the review and the approval! I sent it for review again mainly because I fixed a bunch of conflicts and made the requested changes, so I'd appreciate an extra look. Thanks!

yscik
yscik approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@yscik yscik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

readme.txt Outdated Show resolved Hide resolved
@fjorgemota fjorgemota merged commit 7bc75b3 into feature/upsells Oct 31, 2023
8 checks passed
@fjorgemota fjorgemota deleted the change/rename-addons-to-marketplace branch October 31, 2023 21:49
@github-actions github-actions bot mentioned this pull request Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedebian thedebian thedebian left review comments

@yscik yscik yscik approved these changes

@mikeyarce mikeyarce Awaiting requested review from mikeyarce

Assignees

@fjorgemota fjorgemota

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename references from "add-on" to "Marketplace"
4 participants
@fjorgemota @yscik @thedebian @mikeyarce