Restructure main admin menu #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Because it is literally not used anywhere based on what I could verify
yscik
approved these changes
Oct 12, 2023
assets/css/icons.scss
Outdated
Comment on lines
5
to
9
| url(../font/job-manager.eot?16367094#iefix) format("embedded-opentype"), | ||
| url(../font/job-manager.woff2?16367094) format('woff2'), | ||
| url(../font/job-manager.woff?16367094) format("woff"), | ||
| url(../font/job-manager.ttf?16367094) format("truetype"), | ||
| url(../font/job-manager.svg?16367094#job-manager) format("svg"); |
There was a problem hiding this comment.
There is no need for the extra formats nowadays, woff2 works everywhere:
https://developer.mozilla.org/en-US/docs/Web/CSS/@font-face#browser_compatibility
There was a problem hiding this comment.
Good catch! Removed in 770ac8f. Thanks!
| add_submenu_page( 'edit.php?post_type=job_listing', __( 'Settings', 'wp-job-manager' ), __( 'Settings', 'wp-job-manager' ), 'manage_options', 'job-manager-settings', [ $this->settings_page, 'output' ] ); | ||
|
|
||
| if ( WP_Job_Manager_Helper::instance()->has_licensed_products() || apply_filters( 'job_manager_show_addons_page', true ) ) { | ||
| add_submenu_page( 'edit.php?post_type=job_listing', __( 'WP Job Manager Add-ons', 'wp-job-manager' ), __( 'Add-ons', 'wp-job-manager' ), 'manage_options', 'job-manager-addons', [ $this, 'addons_page' ] ); | ||
| add_submenu_page( 'edit.php?post_type=job_listing', __( 'WP Job Manager Extensions', 'wp-job-manager' ), __( 'Extensions', 'wp-job-manager' ), 'manage_options', 'job-manager-addons', [ $this, 'addons_page' ] ); |
There was a problem hiding this comment.
I think the latest is that we are calling this 'Marketplace': p6r3EZ-1Nu-p2#comment-3379
| @@ -247,7 +247,7 @@ public function register_post_types() { | |||
| 'labels' => [ | |||
| 'name' => $plural, | |||
| 'singular_name' => $singular, | |||
| 'menu_name' => ucwords( $plural ), | |||
| 'menu_name' => __( 'Types', 'wp-job-manager' ), | |||
There was a problem hiding this comment.
Should we also rename 'Job Categories' to 'Categories'?
There was a problem hiding this comment.
This is a good question. I renamed in 2ccdcab, but then we might want to update the Job Tags addon to use only "Tags" on the menu? Not sure.
Because woff2 is already supported by 96% of the browsers
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2586
Changes Proposed in this Pull Request
Testing Instructions
Using this branch of the plugin to test:
Release Notes
Screenshot / Video