Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Promoted Jobs #2451

Merged
merged 381 commits into from
Oct 3, 2023
Merged

Feature: Promoted Jobs #2451

merged 381 commits into from
Oct 3, 2023

Conversation

aaronfc
Copy link
Contributor

@aaronfc aaronfc commented Jun 13, 2023 •
edited by renatho
Loading

Promoted Jobs feature branch.

Changes proposed in this Pull Request

  • It introduces the Promoted Jobs feature to the plugin, where users can promote a job through the JobTarget partner.

Testing instructions

  • This version was already tested pointing to staging and production.
    • If you have the env configured, you can also test pointing to a development wpjobmanager.com site.
  • Make sure the Job Listing displays the Promote button and the plugin is not broken.
Plugin build for 8bd16f7
📦 Download plugin zip
▶️ Open in playground

@aaronfc aaronfc changed the title Feature/promoted jobs Feature: Promoted Jobs Jun 13, 2023
fjorgemota and others added 28 commits July 4, 2023 19:29
@fjorgemota
Use <a /> instead of <button /> for the promote buttons
bca7979
@fjorgemota
Fix PHPDoc comment for add_to_allowed_redirect_hosts
d4400c4
@fjorgemota
Use Promote URL for edit link for promoted listings
19929fc
@fjorgemota
Remove condition to check if job is already promoted
554c2c6 
Because the form to edit the job is the same as the form to create a new job
@fjorgemota
Use admin_action_ in action to deactivate promotion
b83e1fd 
Instead of using generic load-edit.php and checking for deactivate_promotion manually
@fjorgemota
Change method promote_job to handle_promote_job for consistency
82cefcf
@fjorgemota
Use base URL for admin.php for generating promote and deactivate URL …
5a11ef8 
…links
@fjorgemota
Add ID to action passed to nonce and use post_id as query parameter f…
82253df 
…or consistency
@fjorgemota
Fix success message after changing base URL for handling actions to a…
737662e 
…dmin.php
@fjorgemota
Use check_admin_referer to check nonce while deactivating a promotion
030d023 
And return error message when post_id is zero
@fjorgemota
Fix phpcs warning while creating promote_url
edb4c37
@fjorgemota
Use same logic for verifying if the user can promote logic for consis…
38181e5 
…tency
@fjorgemota
Add back_link on the wp_die messages for handle_promote_job
79912e4
@fjorgemota
Show error message if the user doesn't have permission to deactivate …
b8eac8b 
…the promotion
@fjorgemota
Make get_api_base_url public and static
4c3c46b 
So we can get to access that URL from elsewhere
@fjorgemota
Remove slash of the end of get_api_url by default
3a47aa0
@fjorgemota
Get URL to WPJMCOM dynamically in Promoted Jobs admin
869d821 
Useful for supporting dev environments
@mikeyarce
Fallback to previous template if fetch fails
88e5c77
@fjorgemota
Remove old TODO comment
298781e
@fjorgemota
Add parameter with the locale of the user on the query string
a75548b
@fjorgemota
Pass ID of the current user to get the user locale from
7615157
@fjorgemota
Add method to implement endpoint to get job data
a46f108 
With token checking and all the nice things!
@fjorgemota
Register endpoint on the REST server
9f1a5c5
@fjorgemota
Update API Docs to represent new endpoint
4bc97e9
@renatho
Fix promote job button text
991d398
@mikeyarce
Fetch and store template based on user locale
1d7504f
@fjorgemota
Return 404 if the job doesn't exist on get job data for promoted jobs…
4f7eca7 
… API
@fjorgemota
Return 401 if the user doesn't have permission to get job data for pr…
4529c2b 
…omoted jobs API
fjorgemota and others added 17 commits August 17, 2023 22:15
@fjorgemota
Move logic to initialize default options for a static method in Statu…
236e6de 
…s Handler
@fjorgemota
Simplify the logic of the update_interval method
aa6ef7f 
And make it not remove the webhook interval if the value is false or 0
@fjorgemota
Always update LAST_CHECK option when initializing defaults
70e7856 
In case we decide to update WPJMCOM logic to be more strict and somehow the cron runs before the data there is updated
@renatho
Refactor methods to avoid boolean with special string in the same par…
51ebc4b 
…ameter
@renatho
Merge pull request #2562 from Automattic/change/deactivation-approach
8114ae1 
Change deactivation approach
@fjorgemota
Consider current webhook interval when updating LAST CHECK to not blo…
4e0b5a1 
…ck webhook updates
@fjorgemota
Merge branch 'feature/promoted-jobs' into change/dynamic-status-updat…
27c6ad7 
…e-interval
@fjorgemota
Merge pull request #2563 from Automattic/change/dynamic-status-update…
cad0f37 
…-interval
@renatho
Merge branch 'trunk' of github.com:Automattic/WP-Job-Manager into upd…
f10f6b5 
…ate/feature-promoted-jobs
@renatho
Merge branch 'trunk' of github.com:Automattic/WP-Job-Manager into upd…
bf7b75b 
…ate/feature-promoted-jobs
@renatho
Merge pull request #2564 from Automattic/update/feature-promoted-jobs
b116df9 
Update feature promoted jobs
@renatho
Update edit button to manage button
074316c
@renatho
Merge pull request #2567 from Automattic/change/promote-jobs-edit-button
c0b2a61 
Change promote jobs edit button
@jom
Fix bulk update URL
c33327e
@jom
Merge pull request #2570 from Automattic/fix/update-path
d9fab11 
Fix bulk update URL
@renatho
Merge branch 'trunk' of github.com:Automattic/WP-Job-Manager into upd…
4b29e35 
…ate/feature-promoted-jobs
@renatho
Merge pull request #2575 from Automattic/update/feature-promoted-jobs
c06a1be 
Update feature promoted jobs with trunk
@yscik yscik added this to the 2.0.0 milestone Sep 18, 2023
@yscik yscik modified the milestones: 1.42.0, 2.0.0 Oct 2, 2023
@renatho renatho changed the base branch from trunk to release/wp-job-manager-1.42.0 October 3, 2023 14:49
@renatho renatho requested a review from a team October 3, 2023 14:51
@renatho renatho marked this pull request as ready for review October 3, 2023 14:51
@renatho renatho changed the base branch from release/wp-job-manager-1.42.0 to trunk October 3, 2023 14:54
fjorgemota
fjorgemota approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@fjorgemota fjorgemota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving the final approval here so we can merge this, as this feature seems to have been tested a lot already. :D

@renatho renatho merged commit 4b858ce into trunk Oct 3, 2023
7 checks passed
@renatho renatho deleted the feature/promoted-jobs branch October 3, 2023 20:07
@yscik yscik modified the milestones: 2.0.0, 1.42.0 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjorgemota fjorgemota fjorgemota approved these changes

Assignees

@renatho renatho

Labels
None yet
Projects
None yet
Milestone
1.42.0
Development

Successfully merging this pull request may close these issues.
6 participants
@aaronfc @fjorgemota @yscik @renatho @mikeyarce @jom