Update compose dependencies #331
Conversation
AdamGrzybkowski
added
the
dependencies
AdamGrzybkowski
requested review from
hamorillo,
maxledoux and
maxme
and removed request for
maxledoux
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
|
|
It looks like there are some small changes to rendering the |
|
🙃 |
AdamGrzybkowski
force-pushed
the
adam/update_compose
branch
2 times, most recently
from
edd3daa to
8e97075
Compare
| @@ -43,6 +43,7 @@ abstract class RoborazziTest { | |||
| roborazziOptions = RoborazziOptions( | |||
| compareOptions = RoborazziOptions.CompareOptions( | |||
| imageComparator = SimpleImageComparator(maxDistance = 0.007F, hShift = 1), | |||
| changeThreshold = 0.01f, | |||
There was a problem hiding this comment.
Not happy about that, but it's getting quite annoying to have tests fail on CI because of system differences. I made some changes some time ago that fixed the majority of issues, but now there's one test that fails AvatarPickerListLoaded - the dark version passes...
I think this will work for now and when time allows we should modify the CI flow to generate the baseline as per this.
There was a problem hiding this comment.
Yeah, I know the feeling. It's quite annoying. ->
The differ result :ComparisonResult(pixelDifferences=3, pixelCount=1404000, width=1080, height=1300) changed:true
Can we create a ticket to deal with this when possible?
I think this will work for now and when time allows we should modify the CI flow to generate the baseline as per this.
I wonder if you used the wrong link 🤔
There was a problem hiding this comment.
| composeBom = "2024.09.02" | ||
| materialAdaptive = "1.0.0" | ||
| browser = "1.8.0" | ||
| constraintlayout = "2.1.4" | ||
| activity = "1.9.0" | ||
| androidXLifecycle = "2.8.3" | ||
| navigationCompose = "2.8.0-beta05" | ||
| navigationCompose = "2.8.1" |
There was a problem hiding this comment.
We have two more dependencies somehow related with compose that we can update:
activityCompose = "1.9.2"
composeUiTest = "1.7.2"
| @@ -43,6 +43,7 @@ abstract class RoborazziTest { | |||
| roborazziOptions = RoborazziOptions( | |||
| compareOptions = RoborazziOptions.CompareOptions( | |||
| imageComparator = SimpleImageComparator(maxDistance = 0.007F, hShift = 1), | |||
| changeThreshold = 0.01f, | |||
There was a problem hiding this comment.
Yeah, I know the feeling. It's quite annoying. ->
The differ result :ComparisonResult(pixelDifferences=3, pixelCount=1404000, width=1080, height=1300) changed:true
Can we create a ticket to deal with this when possible?
I think this will work for now and when time allows we should modify the CI flow to generate the baseline as per this.
I wonder if you used the wrong link 🤔
AdamGrzybkowski
force-pushed
the
adam/update_compose
branch
from
8e97075 to
09add8e
Compare
Description
This PR updates the compose bom to 2024.09.02 - it includes an update of the material3 library to the latest stable 1.3.0 version with some fixes to the bottom sheet. If we are to force a given version I would rather have the one with fewer bugs.
Additionally, I've updated the compose navigation to a stable version.
Testing Steps
Smoke test QE