Fix PHPUnit tests by updating the database health check #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WPprodigy
approved these changes
Feb 7, 2024
|
|
|
It's part of the mariadb image, I believe: https://mariadb.com/kb/en/using-healthcheck-sh/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking into the logs for the failing PHPUnit tests, I came across this GitHub issue, which describes an identical problem: MariaDB/mariadb-docker#523. (Which is that the mariadb service fails to start, but doesn't have an error message.) The suggested fix was to update the health check command. I assume GitHub Actions is using the health command to detect if the service is running, and something about the old command must not work anymore.
That worked, but then I got a different error that PHPUnit Polyfills was out of date, so I also updated that to v1.1.
For testing instructions, just double check that the PHPUnit checks on this PR ran the test suite :)