Improve performance of is_installed check #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WPprodigy
reviewed
Feb 6, 2024
Co-authored-by: Caleb Burks <[email protected]>
WPprodigy
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed this query performing poorly in some cases, especially when the DB is under load. See this post for more context: p4IuY0-4S6-p2#comment-16728. This PR includes two improvements:
SHOW TABLES LIKE .... Running this query by itself on the mysql replica takes under 10ms, whereas the show tables query is more like 700+ms. (Not the best benchmark, but does verify that it should be better.falseis_installed values. While it shouldn't happen that frequently since Cron Control is active by default, this query otherwise executes a few times every page load, so it should be a nice little improvement.is_installed should execute (at least) on admin pageviews, so you can verify the main changes there.