feat(s3stream): add storage status check #1717
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLFutureX
requested review from
superhx,
SCNieh,
ShadowySpirits and
Chillax-0v0
as code owners
CLFutureX
changed the title
superhx
reviewed
Aug 3, 2024
| @@ -417,7 +419,7 @@ public CompletableFuture<Void> append(AppendContext context, StreamRecordBatch s | |||
| * @return backoff status. | |||
| */ | |||
| public boolean append0(AppendContext context, WalWriteRequest request, boolean fromBackoff) { | |||
| // TODO: storage status check, fast fail the request when storage closed. | |||
| checkStatus(); | |||
There was a problem hiding this comment.
It should be #completeException(new IOException())
There was a problem hiding this comment.
It should be
#completeException(new IOException())
yes, that would be better
There was a problem hiding this comment.
It should invoke WalWriteRequest.cf#completeException
|
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add storage status check