Fix: Handling of multiple bridgehead atom pairs #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was failing to distinguish between forward/reverse directions (and stereoassignments) to decide the canonical direction for this reaction: ``` C1CC2[CH]C1O2 => [CH]1CC2CC1O2 ^ * ^ * ^ * ^* [* marks the first pair of bridgehead stereo atoms] [^ marks the first pair of bridgehead stereo atoms] ``` This now appears to be fixed.
This was another bug affecting this case: ``` C1CC2[CH]C1O2 => [CH]1CC2CC1O2 ^ * ^ * ^ * ^* [* marks the first pair of bridgehead stereo atoms] [^ marks the first pair of bridgehead stereo atoms] ``` Note: The filter for exluding strained stereoisomers is now treating the two pairs of bridgehead atoms as fully independent, resulting in 4 "un-strained" stereoisomers. In reality, I think there should only be 2, but handling that logic correctly seems tricky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.