Skip to content

Commit

Permalink
Migrate to MV3 (Chrome, Firefox, Edge) (#1009)
Browse files Browse the repository at this point in the history
* Migrate to MV3

* fix entry type

* fix default storage area

* fix mv3 migration errors

* further CI fixes

* Fix disable backup policy not working issue (#1050)

* 6.3.5

* typo

* Fix bad practice with argon2-browser

* Remove 'offline_enabled' from manifest

* update test runner and coverage for mv3

* don't use dev config by default

* fix typo (#1144)

* add import QR images/OTP URLs buttons to add account page

* Migrate to MV3

* fix entry type

* fix default storage area

* fix mv3 migration errors

* further CI fixes

* Fix bad practice with argon2-browser

* Remove 'offline_enabled' from manifest

* update test runner and coverage for mv3

* don't use dev config by default

* dump version

* update manifest

* fix ff csp

* remove artifact

* rename test files

* move syncTimeWithGoogle out of popup.ts

this prevents a dependency issue in the tests

* fix the tests, remove code coverage

mv3 makes code cov w/ istanbul virtually impossible due to restrictions on unsafe-eval

* remove testing code

* refactor user settings (#1191)

* remove out-of-date eslint comments

* fix user settings migration issue

* fix user setting migration issue

* fix edge errors

* fix edge issues

* update firefox permissions

* remove all_urls permission since Firefox has supported activeTab

* fix firefox crash due to functions getting added to usersettings object

---------

Co-authored-by: Brendan Early <[email protected]>
Co-authored-by: Zhe Li <[email protected]>
Co-authored-by: spaette <[email protected]>
Co-authored-by: vuittont60 <[email protected]>
  • Loading branch information
5 people authored May 27, 2024
1 parent 2145edc commit df0b859
Show file tree
Hide file tree
Showing 89 changed files with 6,335 additions and 15,385 deletions.
21 changes: 7 additions & 14 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,38 +9,34 @@ jobs:

steps:
- uses: actions/checkout@v2

- name: Setup Node.js environment
uses: actions/[email protected]

- name: Install dependencies
run: |
npm i prettier
sudo npm i -g lintspaces-cli
- name: Prettier
run: ./node_modules/prettier/bin-prettier.js --check ./src/* ./src/**/* ./src/**/**/* ./sass/*.scss

- name: lintspaces
run: |
lintspaces -nt -d 'spaces' -i 'js-comments' src/*/* src/*.ts view/* manifest-*.json css/popup.css css/import.css
build:
runs-on: ubuntu-latest
name: Build ${{ matrix.platform }}

strategy:
matrix:
platform: ["chrome", "firefox"]

steps:
- uses: actions/checkout@v2

- name: Setup Node.js environment
uses: actions/[email protected]

- name: Install dependencies
run: npm ci

- name: Build
run: npm run ${{ matrix.platform }}
run-tests:
Expand All @@ -63,6 +59,3 @@ jobs:
uses: mujo-code/puppeteer-headful@master
with:
args: npm test

- name: Codecov
uses: codecov/[email protected]
6 changes: 3 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
node_modules
build
chrome
firefox
edge
chrome*
firefox*
edge*
dist
.vscode
.atom-build.yml
Expand Down
3 changes: 0 additions & 3 deletions _locales/ar/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "يضيف Authenticator إلى القائمة."
},
"permission_all_urls": {
"message": "الوصول إلى جميع المواقع لمسح رموز QR."
},
"permission_sync_clock": {
"message": "يسمح بمزامنة الساعة مع جوجل."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/bg/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Adds Authenticator to context menu."
},
"permission_all_urls": {
"message": "Access to all websites to scan QR codes."
},
"permission_sync_clock": {
"message": "Allows clock sync with Google."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/bn/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "কনট্যাক্স মেনু তে অথেন্টিকেটর যুক্ত করুন। "
},
"permission_all_urls": {
"message": "কিউআর কোডটি স্ক্যান করার জন্য সকল ওয়েবসাইট অ্যাক্সেস করুন।"
},
"permission_sync_clock": {
"message": "গুগল এর সাথে ঘড়ি সিঙ্ক করুন।"
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/ca/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Afegeix Authenticator al menú contextual."
},
"permission_all_urls": {
"message": "Accés a tots els llocs web per escanejar codis QR."
},
"permission_sync_clock": {
"message": "Permet la sincronització del rellotge amb Google."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/cs/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Přidá Authenticator do kontextové nabídky."
},
"permission_all_urls": {
"message": "Přístup ke všem webům pro skenování QR kódů."
},
"permission_sync_clock": {
"message": "Umožnit synchronizaci hodin s Google."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/da/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Adds Authenticator to context menu."
},
"permission_all_urls": {
"message": "Access to all websites to scan QR codes."
},
"permission_sync_clock": {
"message": "Allows clock sync with Google."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/de/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Fügt Authenticator dem Kontextmenü hinzu."
},
"permission_all_urls": {
"message": "Zugriff auf alle Webseiten, um QR-Codes zu scannen."
},
"permission_sync_clock": {
"message": "Synchronisierung mit Google zulassen."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/el/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Adds Authenticator to context menu."
},
"permission_all_urls": {
"message": "Access to all websites to scan QR codes."
},
"permission_sync_clock": {
"message": "Allows clock sync with Google."
},
Expand Down
9 changes: 6 additions & 3 deletions _locales/en/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -479,15 +479,18 @@
"permission_identity": {
"message": "Allows sign in to 3rd party storage services."
},
"permission_alarms": {
"message": "Allows auto-lock to work."
},
"permission_scripting": {
"message": "Inject scripts into he current tab to scan QR codes and allow auto-fill to work."
},
"permission_clipboard_write": {
"message": "Grants write-only access to the clipboard to copy codes to clipboard when you click on the account."
},
"permission_context_menus": {
"message": "Adds Authenticator to context menu."
},
"permission_all_urls": {
"message": "Access to all websites to scan QR codes."
},
"permission_sync_clock": {
"message": "Allows clock sync with Google."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/es/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Agregar Authenticator al menú contextual."
},
"permission_all_urls": {
"message": "Acceder a los sitios web para poder escanear códigos QR."
},
"permission_sync_clock": {
"message": "Habilitar sincronización del reloj con Google."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/et/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Adds Authenticator to context menu."
},
"permission_all_urls": {
"message": "Access to all websites to scan QR codes."
},
"permission_sync_clock": {
"message": "Allows clock sync with Google."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/fa/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Authenticator را به منوی context اضافه می کند."
},
"permission_all_urls": {
"message": "دسترسی به تمام وب سایت ها برای اسکن کدهای QR."
},
"permission_sync_clock": {
"message": "اجازه همگام سازی ساعت با Google را می دهد."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/fi/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Adds Authenticator to context menu."
},
"permission_all_urls": {
"message": "Access to all websites to scan QR codes."
},
"permission_sync_clock": {
"message": "Allows clock sync with Google."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/fr/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Ajoute Authenticator au menu contextuel."
},
"permission_all_urls": {
"message": "Accès à tous les sites web pour scanner les codes QR."
},
"permission_sync_clock": {
"message": "Autoriser la synchronisation de l'horloge avec Google."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/fy/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Foeget Authenticator ta oan kontekstmenu."
},
"permission_all_urls": {
"message": "Tagong ta alle websites om QR-koaden te scannen."
},
"permission_sync_clock": {
"message": "Tiidssyngronisaasje mei Google tastean."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/he/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Adds Authenticator to context menu."
},
"permission_all_urls": {
"message": "Access to all websites to scan QR codes."
},
"permission_sync_clock": {
"message": "Allows clock sync with Google."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/hi/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "संदर्भ मेनू में प्रमाणक जोड़ता है।"
},
"permission_all_urls": {
"message": "क्यूआर कोड स्कैन करने के लिए सभी वेबसाइटों तक पहुंच।"
},
"permission_sync_clock": {
"message": "घड़ी को Google के साथ सिंक करने की अनुमति देता है।"
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/hr/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Adds Authenticator to context menu."
},
"permission_all_urls": {
"message": "Access to all websites to scan QR codes."
},
"permission_sync_clock": {
"message": "Allows clock sync with Google."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/hu/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Hitelesítő hozzáadása tartalomfüggő menühöz."
},
"permission_all_urls": {
"message": "Minden internet oldal elérése QR-kód beolvasáshoz."
},
"permission_sync_clock": {
"message": "Óra szinkronizálás engedélyezése Google által."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/id/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Adds Authenticator to context menu."
},
"permission_all_urls": {
"message": "Access to all websites to scan QR codes."
},
"permission_sync_clock": {
"message": "Allows clock sync with Google."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/it/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Aggiungi Authenticatori al menu contestuale."
},
"permission_all_urls": {
"message": "Accedi a tutti i siti web per scansionare i codici QR."
},
"permission_sync_clock": {
"message": "Consenti la sincronizzazione dell'orario con Google."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/ja/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "コンテキストメニューに認証システムを追加します。"
},
"permission_all_urls": {
"message": "すべてのウェブサイトにアクセスしてQRコードをスキャンします。"
},
"permission_sync_clock": {
"message": "Google との時刻の同期を許可します。"
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/ko/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "컨텍스트 메뉴에 인증 도구를 추가합니다."
},
"permission_all_urls": {
"message": "QR 코드를 스캔하기 위해 모든 웹 사이트에 액세스 할 수 있습니다."
},
"permission_sync_clock": {
"message": "Google과 시계 동기화를 허용합니다."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/nl/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Voegt Authenticator toe aan contextmenu."
},
"permission_all_urls": {
"message": "Toegang tot alle websites om QR-codes te scannen."
},
"permission_sync_clock": {
"message": "Tijdssynchronisatie met Google toestaan."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/no/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Adds Authenticator to context menu."
},
"permission_all_urls": {
"message": "Access to all websites to scan QR codes."
},
"permission_sync_clock": {
"message": "Allows clock sync with Google."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/pl/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Dodaje dodatek Authenticator do menu kontekstowego."
},
"permission_all_urls": {
"message": "Dostęp do wszystkich stron internetowych w celu skanowania kodów QR."
},
"permission_sync_clock": {
"message": "Umożliwia synchronizację zegara z Google."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/pt/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Adds Authenticator to context menu."
},
"permission_all_urls": {
"message": "Access to all websites to scan QR codes."
},
"permission_sync_clock": {
"message": "Allows clock sync with Google."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/pt_BR/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Adiciona o Autenticador ao menu de contexto."
},
"permission_all_urls": {
"message": "Acesso a todos os sites para escanear códigos QR."
},
"permission_sync_clock": {
"message": "Permite a sincronização de relógio com o Google."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/ro/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Adds Authenticator to context menu."
},
"permission_all_urls": {
"message": "Access to all websites to scan QR codes."
},
"permission_sync_clock": {
"message": "Allows clock sync with Google."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/ru/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Добавляет аутентификатор в меню контекста."
},
"permission_all_urls": {
"message": "Доступ ко всем сайтам для сканирования QR-кодов."
},
"permission_sync_clock": {
"message": "Позволяет синхронизировать часы с Google."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/sq/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Adds Authenticator to context menu."
},
"permission_all_urls": {
"message": "Access to all websites to scan QR codes."
},
"permission_sync_clock": {
"message": "Allows clock sync with Google."
},
Expand Down
3 changes: 0 additions & 3 deletions _locales/sr/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,6 @@
"permission_context_menus": {
"message": "Adds Authenticator to context menu."
},
"permission_all_urls": {
"message": "Access to all websites to scan QR codes."
},
"permission_sync_clock": {
"message": "Allows clock sync with Google."
},
Expand Down
Loading

0 comments on commit df0b859

Please sign in to comment.