Do not send QT (queue time) with SC (session control) as Measurement …

…Protocol gets confused.
AttackPattern · Mar 9, 2014 · 03bbc10 · 03bbc10 · 11RS · Aug 7, 2017
1 parent 0ebcb5e
commit 03bbc10
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/Source/CSharpAnalytics.Tests/Protocols/Measurement/MeasurementAnalyticsClientTests.cs b/Source/CSharpAnalytics.Tests/Protocols/Measurement/MeasurementAnalyticsClientTests.cs
@@ -124,6 +124,16 @@ public void MeasurementAnalyticsClient_AdjustUriBeforeRequest_Adds_Qt_Parameter(
             StringAssert.Contains(actual.Query, "qt=");
         }
 
+        [TestMethod]
+        public void MeasurementAnalyticsClient_AdjustUriBeforeRequest_Does_Not_Add_Qt_Parameter_If_Sc_Parameter_Present()
+        {
+            var originalUri = new Uri("http://anything.really.com/something?sc=start#" + DateTime.UtcNow.ToString("o"));
+
+            var actual = new MeasurementAnalyticsClient().AdjustUriBeforeRequest(originalUri);
+
+            Assert.IsFalse(actual.Query.Contains("qt="));
+        }
+
         [TestMethod]
         public void MeasurementAnalyticsClient_AdjustUriBeforeRequest_Clears_Fragment()
         {

diff --git a/Source/CSharpAnalytics/Protocols/Measurement/MeasurementAnalyticsClient.cs b/Source/CSharpAnalytics/Protocols/Measurement/MeasurementAnalyticsClient.cs
@@ -174,7 +174,7 @@ public Uri AdjustUriBeforeRequest(Uri uri)
         /// <param name="parameters">URI parameters to add the relative QT parameter to.</param>
         private static void AddQueueTimeFromFragment(Uri uri, IDictionary<string, string> parameters)
         {
-            if (String.IsNullOrWhiteSpace(uri.Fragment)) return;
+            if (String.IsNullOrWhiteSpace(uri.Fragment) || parameters.ContainsKey("sc")) return;
             var decodedFragment = uri.GetComponents(UriComponents.Fragment, UriFormat.Unescaped);
 
             DateTime utcHitTime;